danielcweeks commented on code in PR #14333:
URL: https://github.com/apache/iceberg/pull/14333#discussion_r2519907178
##########
gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSOutputFile.java:
##########
@@ -34,12 +35,20 @@ class GCSOutputFile extends BaseGCSFile implements
OutputFile {
static GCSOutputFile fromLocation(
String location, PrefixedStorage storage, MetricsContext metrics) {
return new GCSOutputFile(
- storage.storage(), BlobId.fromGsUtilUri(location),
storage.gcpProperties(), metrics);
+ storage.storage(),
+ storage.gcsFileSystem(),
Review Comment:
Do we really need to go through this path for writes? What improvements or
changes is it making to the write behavior that Storage doesn't already
provide? This isn't clear from the
[documentation](https://github.com/GoogleCloudPlatform/gcs-analytics-core) on
the library, which feels a little light on details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
