danielcweeks commented on PR #14161: URL: https://github.com/apache/iceberg/pull/14161#issuecomment-3519268715
Hey @anuragmantri , this looks really close, but I think it's a little cleaner if we pull the external `ManagedHttpClientRegistry` into a base class that the other extend from. I don't see any reason why we would need to expose that cache externally, so it's probably better to encapsulate it as much as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
