nbdevos25 commented on code in PR #14560:
URL: https://github.com/apache/iceberg/pull/14560#discussion_r2515456706


##########
build.gradle:
##########
@@ -1024,7 +1023,8 @@ project(':iceberg-open-api') {
   dependencies {
     testImplementation project(':iceberg-api')
     testImplementation project(':iceberg-core')
-    testImplementation 
project(':iceberg-core').sourceSets.test.runtimeClasspath
+    testImplementation project(path: ':iceberg-api', configuration: 
'testArtifacts')

Review Comment:
   removing 
   `testImplementation project(path: ':iceberg-api', configuration: 
'testArtifacts')` causes following failures - 
   
   ```
   > Task :iceberg-open-api:test
   RESTCompatibilityKitCatalogTests > testRegisterTable() FAILED
       java.lang.NoClassDefFoundError: org/apache/iceberg/TestHelpers
           at 
org.apache.iceberg.catalog.CatalogTests.testRegisterTable(CatalogTests.java:3139)
           at java.base/java.lang.reflect.Method.invoke(Method.java:580)
           at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
           at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
   
           Caused by:
           java.lang.ClassNotFoundException: org.apache.iceberg.TestHelpers
               at 
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:642)
               at 
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
               at 
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
               ... 4 more
   
   Iceberg REST Compatibility Kit > JUnit Jupiter > 
RESTCompatibilityKitCatalogTests > testRegisterTable() FAILED
       java.lang.NoClassDefFoundError: org/apache/iceberg/TestHelpers
           at 
org.apache.iceberg.catalog.CatalogTests.testRegisterTable(CatalogTests.java:3139)
           at java.base/java.lang.reflect.Method.invoke(Method.java:580)
           at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
           at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
   
           Caused by:
           java.lang.ClassNotFoundException: org.apache.iceberg.TestHelpers
               at 
org.apache.iceberg.catalog.CatalogTests.testRegisterTable(CatalogTests.java:3139)
               ... 3 more
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to