kevinjqliu opened a new pull request, #2734:
URL: https://github.com/apache/iceberg-python/pull/2734

   <!--
   Thanks for opening a pull request!
   -->
   
   <!-- In the case this PR will resolve an issue, please replace 
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
   <!-- Closes #${GITHUB_ISSUE_ID} -->
   
   # Rationale for this change
   Follow up to #2601 
   clean up .egg-info/ and setup.cfg from sdist
   
   ## Are these changes tested?
   Yes
   
   Check the new sdist
   ```
   rm -rf dist build pyiceberg.egg-info
   uv build --sdist
   tar -tzf dist/pyiceberg-*.tar.gz | grep -E "(build/|setup.cfg|\.egg-info)"
   ```
   
   Diffed too
   ```
   diff -qr ./dist/pyiceberg-0.10.0 ~/Downloads/nightly/sdist/ | sort
   
   differ
       Files ./dist/pyiceberg-0.10.0/Makefile and 
/Users/kevinliu/Downloads/nightly/sdist/Makefile differ
       Files ./dist/pyiceberg-0.10.0/PKG-INFO and 
/Users/kevinliu/Downloads/nightly/sdist/PKG-INFO differ
       Files ./dist/pyiceberg-0.10.0/dev/.rat-excludes and 
/Users/kevinliu/Downloads/nightly/sdist/dev/.rat-excludes differ
       Files ./dist/pyiceberg-0.10.0/pyproject.toml and 
/Users/kevinliu/Downloads/nightly/sdist/pyproject.toml differ
   new
       Only in ./dist/pyiceberg-0.10.0/tests: .DS_Store
       Only in ./dist/pyiceberg-0.10.0: MANIFEST.in
       Only in ./dist/pyiceberg-0.10.0: setup.py
   removed
       Only in /Users/kevinliu/Downloads/nightly/sdist: build-module.py
       Only in /Users/kevinliu/Downloads/nightly/sdist: poetry.lock
   ```
   
   In sdist, ran RAT check and tests
   ```
   make check-license
   make test-coverage
   ```
   
   ## Are there any user-facing changes?
   
   <!-- In the case of user-facing changes, please add the changelog label. -->
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to