CTTY commented on code in PR #1827:
URL: https://github.com/apache/iceberg-rust/pull/1827#discussion_r2513033540
##########
crates/integrations/datafusion/src/task_writer.rs:
##########
@@ -139,17 +132,29 @@ impl<B: IcebergWriterBuilder> TaskWriter<B> {
SupportedWriter::Clustered(ClusteredWriter::new(writer_builder))
};
+ // Initialize partition splitter in constructor for partitioned tables
+ let partition_splitter = if !partition_spec.is_unpartitioned() {
+ Some(
+ RecordBatchPartitionSplitter::new_with_precomputed_values(
+ schema.clone(),
+ partition_spec.clone(),
+ )
+ .expect("Failed to create partition splitter"),
Review Comment:
Fixed! I've also renamed some constructors from `new` to `try_new` since we
are returning `Result`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
