HuaHuaY commented on code in PR #281:
URL: https://github.com/apache/iceberg-cpp/pull/281#discussion_r2513029035
##########
src/iceberg/catalog/memory/in_memory_catalog.cc:
##########
@@ -415,6 +415,12 @@ Status InMemoryCatalog::DropTable(const TableIdentifier&
identifier, bool purge)
return root_namespace_->UnregisterTable(identifier);
}
+Status InMemoryCatalog::RenameTable(const TableIdentifier& from,
+ const TableIdentifier& to) {
+ std::unique_lock lock(mutex_);
Review Comment:
If we don't need to move `lock`, we can use `std::lock_guard<>` instead. Can
you help to modify the other cases in this file? Or we can open a new PR to do
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
