liurenjie1024 commented on PR #1362: URL: https://github.com/apache/iceberg-rust/pull/1362#issuecomment-3514695656
> @liurenjie1024 thanks for your review and sorry for letting this drag so long. I switched now to a much simpler approach that just uses a `build_unchecked` method to construct the `TableMetadata`. I believe this is by far the most maintainable, as it is just derived. I am ok with a breaking change in this builder if the `TableMetadata` object changes, in fact, I would expect it. We do have a stable builder already that works imperative. This builder is just here to construct this specific struct from its parts, so I think its ok that the builder changes if the struct changes. Hi, @c-thiel As I said, I have strong concerns on using typed builder here to auto generated codes on such a large struct, could we maintain this builder manually? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
