davseitsev commented on code in PR #12892:
URL: https://github.com/apache/iceberg/pull/12892#discussion_r2510292903
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java:
##########
@@ -69,7 +69,9 @@ public abstract class TestBaseWithCatalog extends TestBase {
// status even belonging to the same catalog. Reference:
// https://www.sqlite.org/inmemorydb.html
CatalogProperties.CLIENT_POOL_SIZE,
- "1"));
+ "1",
+ CatalogProperties.UNIQUE_TABLE_LOCATION,
+ "true"));
Review Comment:
Yes, it is. I don’t see an easy way to avoid this. To make
`UNIQUE_TABLE_LOCATION` configurable, I would either have to stop using
`TestBaseWithCatalog` or update all of its implementations, which feels
disproportionate for this change.
Longer term, I think it would make sense for `UNIQUE_TABLE_LOCATION` to
default to `true`, similar to `NessieCatalog`, because non-unique table
locations feel more like an issue than a rarely used feature to me.
For now, I’ve disabled the tests related to unique table locations for REST
catalogs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
