wgtmac commented on code in PR #299:
URL: https://github.com/apache/iceberg-cpp/pull/299#discussion_r2504200402
##########
src/iceberg/json_internal.cc:
##########
@@ -529,7 +528,7 @@ Result<std::unique_ptr<PartitionSpec>>
PartitionSpecFromJson(
ICEBERG_ASSIGN_OR_RAISE(auto partition_field,
PartitionFieldFromJson(field_json));
partition_fields.push_back(std::move(*partition_field));
}
- return std::make_unique<PartitionSpec>(schema, spec_id,
std::move(partition_fields));
+ return std::make_unique<PartitionSpec>(spec_id, std::move(partition_fields));
Review Comment:
As discussed offline, we cannot use the unbound form here. Instead, we need
to use a new `PartitionSpec::Make` to find the source field of each partition
field from `schema` and then verify it is acceptable by the transform object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
