aiborodin commented on code in PR #14509: URL: https://github.com/apache/iceberg/pull/14509#discussion_r2501261747
########## api/src/main/java/org/apache/iceberg/SnapshotAncestryValidator.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.function.Function; +import javax.annotation.Nonnull; + +/** + * Interface to support validating snapshot ancestry during the commit process. + * + * <p>Validation will be called after the table metadata is refreshed to pick up any changes to the + * table state. + */ +@FunctionalInterface +public interface SnapshotAncestryValidator extends Function<Iterable<Snapshot>, Boolean> { + + SnapshotAncestryValidator NON_VALIDATING = baseSnapshots -> true; + + /** + * Validate the snapshots based on the refreshed table state. + * + * @param baseSnapshots ancestry of the base table metadata snapshots + * @return boolean for whether the update is valid + */ + @Override + Boolean apply(Iterable<Snapshot> baseSnapshots); Review Comment: > There's no guarantee (and it's very commonly not the case) that the offsets will be in the prior commit. https://github.com/apache/iceberg/pull/14515 checks all new commits when configured with the starting snapshot id. Wouldn't the current approach results in unnecessary checks of the whole Snapshot history on every validation run? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
