danielcweeks commented on code in PR #14503: URL: https://github.com/apache/iceberg/pull/14503#discussion_r2495622892
########## core/src/main/java/org/apache/iceberg/SupportsCommitValidation.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.function.BiConsumer; +import org.apache.iceberg.exceptions.CommitFailedException; + +public interface SupportsCommitValidation { + CommitValidator NON_VALIDATING = (base, metadata) -> {}; + + @FunctionalInterface + interface CommitValidator extends BiConsumer<TableMetadata, TableMetadata> { + @Override + void accept(TableMetadata base, TableMetadata current); + } + + /** + * Commits the updated metadata to the table taking a validator that will be called with the + * refreshed metadata and pending metadata. + * <p> + * The validator should throw a {@link CommitFailedException} if validation fails. Retries will still Review Comment: We retry on `CommitFailedException`, so I think there's a question as to whether there's any scenario where a retry could result in a successful commit. I'm not clear whether that is a reasonable assumption. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
