huaxingao commented on code in PR #14277:
URL: https://github.com/apache/iceberg/pull/14277#discussion_r2492931933
##########
api/src/main/java/org/apache/iceberg/types/Comparators.java:
##########
@@ -76,6 +76,11 @@ public static <T> Comparator<T> forType(Type.PrimitiveType
type) {
throw new UnsupportedOperationException("Cannot determine comparator for
type: " + type);
}
+ @SuppressWarnings("unchecked")
+ public static <T> Comparator<T> forType(Type type) {
+ return internal(type);
+ }
+
@SuppressWarnings("unchecked")
private static <T> Comparator<T> internal(Type type) {
Review Comment:
I prefer option 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
