colinmarc commented on code in PR #1569:
URL: https://github.com/apache/iceberg-rust/pull/1569#discussion_r2490595824
##########
crates/integrations/datafusion/src/physical_plan/expr_to_predicate.rs:
##########
@@ -429,4 +497,76 @@ mod tests {
let predicate = convert_to_iceberg_predicate(sql);
assert_eq!(predicate, None);
}
+
+ #[test]
+ fn test_predicate_conversion_with_timestamp() {
+ // 2023-01-01 12:00:00 UTC
+ let timestamp_scalar = ScalarValue::TimestampSecond(Some(1672574400),
None);
+ let dt =
DateTime::parse_from_rfc3339("2023-01-01T12:00:00+00:00").unwrap();
Review Comment:
I gave it a shot, but these tests are a lot more complicated than the tests
in `values.rs` so it ended up being pretty ugly and I backed it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
