mbutrovich commented on code in PR #1821:
URL: https://github.com/apache/iceberg-rust/pull/1821#discussion_r2487874244
##########
crates/iceberg/src/scan/task.rs:
##########
@@ -54,6 +58,24 @@ pub struct FileScanTask {
/// The list of delete files that may need to be applied to this data file
pub deletes: Vec<FileScanTaskDeleteFile>,
+
+ /// Partition data from the manifest entry, used to identify which columns
can use
+ /// constant values from partition metadata vs. reading from the data file.
+ /// Per the Iceberg spec, only identity-transformed partition fields
should use constants.
+ #[serde(skip)]
+ pub partition: Option<Struct>,
Review Comment:
Struct is not serializable, so we're skipping all of these new fields for
now. I will open a followup issue per the discussion in
https://github.com/apache/iceberg-rust/issues/1815.
##########
crates/iceberg/src/scan/task.rs:
##########
@@ -54,6 +58,24 @@ pub struct FileScanTask {
/// The list of delete files that may need to be applied to this data file
pub deletes: Vec<FileScanTaskDeleteFile>,
+
+ /// Partition data from the manifest entry, used to identify which columns
can use
+ /// constant values from partition metadata vs. reading from the data file.
+ /// Per the Iceberg spec, only identity-transformed partition fields
should use constants.
+ #[serde(skip)]
+ pub partition: Option<Struct>,
Review Comment:
`Struct` is not serializable, so we're skipping all of these new fields for
now. I will open a followup issue per the discussion in
https://github.com/apache/iceberg-rust/issues/1815.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
