huaxingao commented on code in PR #14349:
URL: https://github.com/apache/iceberg/pull/14349#discussion_r2479074715


##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/data/SparkParquetReaders.java:
##########
@@ -776,7 +776,7 @@ public MapData getMap(int ordinal) {
 
     @Override
     public VariantVal getVariant(int ordinal) {
-      throw new UnsupportedOperationException("Unsupported method: 
getVariant");
+      return (VariantVal) values[ordinal];

Review Comment:
   I think it can only be `VariantVal` here. Also other methods in this class 
don't have a precondition check. I prefer to be consistent with other methods. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to