singhpk234 commented on code in PR #14448:
URL: https://github.com/apache/iceberg/pull/14448#discussion_r2477285718
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -262,7 +262,9 @@ paths:
An optional namespace, underneath which to list namespaces.
If not provided, all top-level namespaces should be listed.
For backward compatibility, empty string is treated as absent for
now.
- If parent is a multipart namespace, the parts must be separated by
the unit separator (`0x1F`) byte.
+ If parent is a multipart namespace, the parts must be separated by
the namespace separator as
+ indicated via the /config override `namespace-separator`, which
defaults to the unit separator (`0x1F`) byte.
Review Comment:
how about we name this conf `nested-namespace-separator` ?
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -262,7 +262,9 @@ paths:
An optional namespace, underneath which to list namespaces.
If not provided, all top-level namespaces should be listed.
For backward compatibility, empty string is treated as absent for
now.
- If parent is a multipart namespace, the parts must be separated by
the unit separator (`0x1F`) byte.
+ If parent is a multipart namespace, the parts must be separated by
the namespace separator as
+ indicated via the /config override `namespace-separator`, which
defaults to the unit separator (`0x1F`) byte.
+ To be compatible with older clients, servers must use both the
advertised separator and `0x1F` as valid separators when decoding namespaces.
Review Comment:
[doubt] I see is then, there no way then `0x1F` can be surely considered as
a non-seperator ? even when the client supports adhering to advertised
seperator and is doing that ?
Or may be if servers wanna support that they can capture `X-Iceberg-Version`
header and see if the client supports this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
