zeroshade commented on code in PR #612:
URL: https://github.com/apache/iceberg-go/pull/612#discussion_r2466314252
##########
catalog/internal/utils.go:
##########
@@ -31,40 +32,48 @@ import (
"github.com/apache/iceberg-go"
"github.com/apache/iceberg-go/catalog"
- "github.com/apache/iceberg-go/io"
+ icebergio "github.com/apache/iceberg-go/io"
"github.com/apache/iceberg-go/table"
"github.com/google/uuid"
)
-func GetMetadataLoc(location string, newVersion uint) string {
- return fmt.Sprintf("%s/metadata/%05d-%s.metadata.json",
- location, newVersion, uuid.New().String())
-}
Review Comment:
was this function not being used at all?
##########
catalog/internal/utils.go:
##########
@@ -31,40 +32,48 @@ import (
"github.com/apache/iceberg-go"
"github.com/apache/iceberg-go/catalog"
- "github.com/apache/iceberg-go/io"
+ icebergio "github.com/apache/iceberg-go/io"
"github.com/apache/iceberg-go/table"
"github.com/google/uuid"
)
-func GetMetadataLoc(location string, newVersion uint) string {
- return fmt.Sprintf("%s/metadata/%05d-%s.metadata.json",
- location, newVersion, uuid.New().String())
-}
-
-func WriteTableMetadata(metadata table.Metadata, fs io.WriteFileIO, loc
string) error {
+func WriteTableMetadata(metadata table.Metadata, fs icebergio.WriteFileIO, loc
string, compression string) error {
Review Comment:
compression should probably be an enum and we should error if it's not an
empty string or one we recognize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
