liurenjie1024 commented on code in PR #1777:
URL: https://github.com/apache/iceberg-rust/pull/1777#discussion_r2464920736
##########
crates/iceberg/src/arrow/reader.rs:
##########
@@ -316,13 +317,53 @@ impl ArrowReader {
record_batch_stream_builder
.build()?
.map(move |batch| match batch {
- Ok(batch) =>
record_batch_transformer.process_record_batch(batch),
+ Ok(batch) => {
+ // If we used position-based fallback, add field ID
metadata to the schema
+ let batch_with_metadata = if let Some(ref mapping) =
arrow_pos_to_field_id {
+ Self::add_field_id_metadata_to_batch(batch,
mapping)?
Review Comment:
Do we need to do this for every record batch? I think we only need to do it
once per file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
