dttung2905 commented on code in PR #605:
URL: https://github.com/apache/iceberg-go/pull/605#discussion_r2463923313
##########
schema.go:
##########
@@ -79,6 +79,11 @@ func NewSchemaWithIdentifiers(id int, identifierIDs []int,
fields ...NestedField
}
func (s *Schema) init() {
+ // Validate unknown type requirements
+ if err := s.validateUnknownTypes(); err != nil {
+ panic(fmt.Sprintf("Invalid schema: %v", err))
+ }
Review Comment:
Thanks for the review. I think returning this in `init()` will have a
cascading effect on many places in the code base. Let me look for some other
places to validate the unknownTypes else, I'm happy to remove the validation of
unknown type altogether :D . wydt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
