szehon-ho commented on code in PR #14380:
URL: https://github.com/apache/iceberg/pull/14380#discussion_r2453062032
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1521,6 +1521,13 @@ public Builder setPreviousFileLocation(String
previousFileLocation) {
return this;
}
+ public Builder setLastUpdatedMillisIfNull(long lastUpdatedAt) {
+ if (this.lastUpdatedMillis == null) {
Review Comment:
just my thought, its a bit strange to have a builder silently ignore an
argument. i guess its from:
https://github.com/apache/iceberg/pull/14380#discussion_r2449280988 ?
It would make more sense to assert (or perhaps check precondition) , as i
think the comment suggested ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
