pvary commented on code in PR #14197:
URL: https://github.com/apache/iceberg/pull/14197#discussion_r2447675140
##########
data/src/test/java/org/apache/iceberg/io/TestTaskEqualityDeltaWriter.java:
##########
@@ -462,9 +502,12 @@ private void withGranularity(DeleteGranularity
granularity) throws IOException {
// Should have 2 files, as BaseRollingWriter checks the size on every 1000
rows (ROWS_DIVISOR)
assertThat(result.dataFiles()).as("Should have 2 data files.").hasSize(2);
- assertThat(result.deleteFiles())
- .as("Should have correct number of pos-delete files")
- .hasSize(granularity.equals(DeleteGranularity.FILE) ? 2 : 1);
+ if (formatVersion == FORMAT_V2) {
+ assertThat(result.deleteFiles())
+ .as("Should have correct number of pos-delete files")
+ .hasSize(granularity.equals(DeleteGranularity.FILE) ? 2 : 1);
+ }
Review Comment:
do we need to have an `else`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
