geruh commented on code in PR #14341: URL: https://github.com/apache/iceberg/pull/14341#discussion_r2446454468
########## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.actions; + +import org.apache.iceberg.ManifestFile; + +/** An action that will repair manifests. Implementations should produce a new set of manifests. */ +public interface RepairManifests extends SnapshotUpdate<RepairManifests, RepairManifests.Result> { + + /** + * Configuration method for repairing manifest entry statistics + * + * @return this for method chaining + */ + RepairManifests repairEntryStats(); + + /** + * Configuration method for removing duplicate file entries and removing files which no longer + * exist in storage + * + * @return this for method chaining + */ + RepairManifests repairFileEntries(); + + /** + * Configuration option to preview repair manifest operation without actually committing the + * operation to the table + * + * @return this for method chaining + */ + RepairManifests dryRun(); + + /** The action result that contains a summary of the execution. */ + interface Result { + /** Returns rewritten manifests. */ + Iterable<ManifestFile> rewrittenManifests(); + + /** Returns the number of duplicate file entries that were removed from manifests */ + long duplicateFilesRemoved(); + + /** Returns the number of missing file references that were removed from manifests */ + long missingFilesRemoved(); + + /** Returns the number of missing files that were successfully recovered. */ + long missingFilesRecovered(); + + /** Returns the number of manifest entries for which stats were incorrect */ + long entryStatsIncorrectCount(); + + /** Returns the number of manifest entries for which stats were corrected */ + long entryStatsRepairedCount(); Review Comment: Yeah, truly we only care about what was corrected here. I initially had the distinction because if there were failures (though not sure that's a real case here), we could document them. But more importantly, for the case where we run without the repair flag, we could report how many incorrect entry stats you have. But looking back now, it wouldn't make sense to differentiate since If repair fails, the operation would likely fail entirely rather than partially succeed and incorrect count is the same as repaired in a normal op. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
