Fokko commented on code in PR #2565:
URL: https://github.com/apache/iceberg-python/pull/2565#discussion_r2445285605
##########
tests/expressions/test_expressions.py:
##########
@@ -702,6 +702,10 @@ def test_or() -> None:
# Some syntactic sugar
assert or_ == null | nan
+ assert (
+ or_.model_dump_json()
+ ==
'{"type":"or","left":"IsNull(term=Reference(name=\'a\'))","right":"IsNaN(term=Reference(name=\'b\'))"}'
Review Comment:
This test is invalid, it should return something like:
```suggestion
==
'{"type":"or","left":{"type":"is-null","term":"a"},"right":{"type":"is-nan","term":"b"}}'
```
But the unary predicates are still WIP:
https://github.com/apache/iceberg-python/pull/2598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
