mxm commented on PR #14358: URL: https://github.com/apache/iceberg/pull/14358#issuecomment-3421919467
> > I conclude that a fix in DynamicWriter is _not_ required. The reason is that the OutputFileFactory (in Iceberg core), in contrast to ManifestOutputFileFactory, is already scoped via a random uuid for the operation id: > > https://github.com/apache/iceberg/blob/04e51ba6d2a44b4a3bf71241b1777a54202823a4/core/src/main/java/org/apache/iceberg/io/OutputFileFactory.java#L138 > > > > . We call it from here: > > https://github.com/apache/iceberg/blob/04e51ba6d2a44b4a3bf71241b1777a54202823a4/flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/RowDataTaskWriterFactory.java#L171 > > > > I've pushed a test to verify that. > > The funny thing is that the unique part there is `operationId` and the `suffix` is different (not used). Yes, I discovered that when I tried using the suffix to insert a UUID, but the file path already contained a UUID which kept changing. I suppose we could replace the operator id from ManifestOutputFileFactory, but that's maybe something for another day. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
