Guosmilesmile commented on code in PR #14312:
URL: https://github.com/apache/iceberg/pull/14312#discussion_r2444826438
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriteResultAggregator.java:
##########
@@ -125,26 +126,42 @@ public void prepareSnapshotPreBarrier(long checkpointId)
throws IOException {
}
/**
- * Write all the completed data files to a newly created manifest file and
return the manifest's
+ * Write all the completed data files to a newly created manifest files and
return the manifests'
* avro serialized bytes.
*/
@VisibleForTesting
- byte[] writeToManifest(
- WriteTarget key, Collection<DynamicWriteResult> writeResults, long
checkpointId)
+ byte[][] writeToManifests(
+ String tableName, Collection<WriteResult> writeResults, long
checkpointId)
Review Comment:
Personally, a seamless upgrade feels like a big win to me (as long as it
doesn’t require a huge engineering effort).
When users have to perform extra steps during an upgrade, it’s confusing—and
even scary—because they can’t tell whether the extra work is caused by this
feature or by something else entirely. If we can make the upgrade invisible, we
spare them that confusion and fear, which is awesome.
So IMHO it’s worth the effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
