zhjwpku commented on code in PR #237:
URL: https://github.com/apache/iceberg-cpp/pull/237#discussion_r2442729104


##########
.github/workflows/docs.yml:
##########
@@ -0,0 +1,56 @@
+name: "Release Docs"
+
+on:
+  workflow_dispatch:
+  pull_request:
+    branches:
+      - main

Review Comment:
   Do we need to build the doc for each release tag?



##########
.github/workflows/docs.yml:
##########
@@ -0,0 +1,56 @@
+name: "Release Docs"
+
+on:
+  workflow_dispatch:
+  pull_request:
+    branches:
+      - main
+    paths:
+      - 'mkdocs/**'
+      - 'src/**'
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
+permissions:
+  contents: write
+
+jobs:
+  docs:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v5
+        with:
+          fetch-depth: 0

Review Comment:
   Do we need all history of the repo for doc release? If not, the default 1 
should be fine.
   
   https://github.com/actions/checkout/blob/main/README.md?plain=1#L120



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to