kevinjqliu commented on code in PR #588:
URL: https://github.com/apache/iceberg-go/pull/588#discussion_r2408707991
##########
.github/workflows/rc.yml:
##########
@@ -53,72 +48,24 @@ jobs:
echo "RC=${rc}" >> ${GITHUB_ENV}
echo "VERSION=${version}"
echo "RC=${rc}"
- - name: Prepare for branch
- if: github.ref_type == 'branch'
- run: |
- rc=100
- echo "VERSION=${version}" >> ${GITHUB_ENV}
- echo "RC=${rc}" >> ${GITHUB_ENV}
- echo "VERSION=${version}"
- echo "RC=${rc}"
- name: Archive
run: |
- id="apache-iceberg-go-${VERSION}-rc${RC}"
- tar_gz="${id}.tar.gz"
- echo "TAR_GZ=${tar_gz}" >> ${GITHUB_ENV}
- git archive HEAD --prefix "${id}/" --output "${tar_gz}"
+ # tar.gz file has the format
apache-iceberg-go-<version>-rc<rc>.tar.gz
+ # and contains a directory named apache-iceberg-go-<version> with
the source
+ dir="apache-iceberg-go-${VERSION}"
Review Comment:
dir name inside tar.gz (after after untar)
matches `dev/release/verify_rc.sh`
##########
dev/release/verify_rc.sh:
##########
@@ -36,7 +36,7 @@ RC="$2"
ICEBERG_DIST_BASE_URL="https://downloads.apache.org/iceberg";
DOWNLOAD_RC_BASE_URL="https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-go-${VERSION}-rc${RC}";
-ARCHIVE_BASE_NAME="apache-iceberg-go-${VERSION}-rc${RC}"
+ARCHIVE_BASE_NAME="apache-iceberg-go-${VERSION}"
Review Comment:
this is the dir name after untar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
