HuaHuaY commented on code in PR #238:
URL: https://github.com/apache/iceberg-cpp/pull/238#discussion_r2371476719
##########
src/iceberg/expression/literal.h:
##########
@@ -56,7 +60,8 @@ class ICEBERG_EXPORT Literal {
double, // for double
std::string, // for string
std::vector<uint8_t>, // for binary, fixed
- std::array<uint8_t, 16>, // for uuid and decimal
+ std::array<uint8_t, 16>, // for uuid
+ int128_t, // for decimal
Review Comment:
See https://github.com/apache/iceberg-cpp/pull/206#discussion_r2371280533. I
think it's better to use the wrapper class `Decimal` here. And use
`Decimal(Decimal value, int32_t precision, int32_t scale)` to create a literal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
