pvary commented on code in PR #12892:
URL: https://github.com/apache/iceberg/pull/12892#discussion_r2429487896


##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -123,7 +123,11 @@ public void createCatalog() throws Exception {
     this.backendCatalog = new InMemoryCatalog();
     this.backendCatalog.initialize(
         "in-memory",
-        ImmutableMap.of(CatalogProperties.WAREHOUSE_LOCATION, 
warehouse.getAbsolutePath()));
+        ImmutableMap.of(
+            CatalogProperties.WAREHOUSE_LOCATION,
+            warehouse.getAbsolutePath(),
+            CatalogProperties.UNIQUE_TABLE_LOCATION,
+            "true"));

Review Comment:
   Does this mean that the default value for these tests is always true?
   I'm not sure we would like to do this.
   
   Could we just set in cases where it is needed for the tests explicitly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to