pvary commented on code in PR #12298:
URL: https://github.com/apache/iceberg/pull/12298#discussion_r2378163518
##########
core/src/main/java/org/apache/iceberg/data/DeleteLoader.java:
##########
Review Comment:
You are right. This was something which was required when the DeleteFilter
was part of the ReadBuilder API.
Since we removed it from there, this move is not needed.
Moved back to the original place
##########
core/src/main/java/org/apache/iceberg/deletes/PositionDeleteWriter.java:
##########
@@ -66,12 +66,38 @@ public PositionDeleteWriter(
PartitionSpec spec,
StructLike partition,
EncryptionKeyMetadata keyMetadata) {
+ this(
+ appender,
+ format,
+ location,
+ spec,
+ partition,
+ keyMetadata != null ? keyMetadata.buffer() : null);
+ }
+
+ public PositionDeleteWriter(PositionDeleteWriter<T> wrapped) {
Review Comment:
Reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
