wgtmac commented on code in PR #177:
URL: https://github.com/apache/iceberg-cpp/pull/177#discussion_r2375998647
##########
src/iceberg/expression/expression.cc:
##########
@@ -87,4 +91,100 @@ bool Or::Equals(const Expression& expr) const {
return false;
}
+std::string_view ToString(Expression::Operation op) {
+ switch (op) {
+ case Expression::Operation::kAnd:
+ return "AND";
+ case Expression::Operation::kOr:
+ return "OR";
+ case Expression::Operation::kTrue:
+ return "TRUE";
+ case Expression::Operation::kFalse:
+ return "FALSE";
+ case Expression::Operation::kIsNull:
+ return "IS_NULL";
+ case Expression::Operation::kNotNull:
+ return "NOT_NULL";
+ case Expression::Operation::kIsNan:
+ return "IS_NAN";
+ case Expression::Operation::kNotNan:
+ return "NOT_NAN";
+ case Expression::Operation::kLt:
+ return "LT";
+ case Expression::Operation::kLtEq:
+ return "LT_EQ";
+ case Expression::Operation::kGt:
+ return "GT";
+ case Expression::Operation::kGtEq:
+ return "GT_EQ";
+ case Expression::Operation::kEq:
+ return "EQ";
+ case Expression::Operation::kNotEq:
+ return "NOT_EQ";
+ case Expression::Operation::kIn:
+ return "IN";
+ case Expression::Operation::kNotIn:
+ return "NOT_IN";
+ case Expression::Operation::kStartsWith:
+ return "STARTS_WITH";
+ case Expression::Operation::kNotStartsWith:
+ return "NOT_STARTS_WITH";
+ case Expression::Operation::kCount:
+ return "COUNT";
+ case Expression::Operation::kNot:
+ return "NOT";
+ case Expression::Operation::kCountStar:
+ return "COUNT_STAR";
+ case Expression::Operation::kMax:
+ return "MAX";
+ case Expression::Operation::kMin:
+ return "MIN";
+ }
+ std::unreachable();
+}
+
+Result<Expression::Operation> Negate(Expression::Operation op) {
+ switch (op) {
+ case Expression::Operation::kIsNull:
+ return Expression::Operation::kNotNull;
+ case Expression::Operation::kNotNull:
+ return Expression::Operation::kIsNull;
+ case Expression::Operation::kIsNan:
+ return Expression::Operation::kNotNan;
+ case Expression::Operation::kNotNan:
+ return Expression::Operation::kIsNan;
+ case Expression::Operation::kLt:
+ return Expression::Operation::kGtEq;
+ case Expression::Operation::kLtEq:
+ return Expression::Operation::kGt;
+ case Expression::Operation::kGt:
+ return Expression::Operation::kLtEq;
+ case Expression::Operation::kGtEq:
+ return Expression::Operation::kLt;
+ case Expression::Operation::kEq:
+ return Expression::Operation::kNotEq;
+ case Expression::Operation::kNotEq:
+ return Expression::Operation::kEq;
+ case Expression::Operation::kIn:
+ return Expression::Operation::kNotIn;
+ case Expression::Operation::kNotIn:
+ return Expression::Operation::kIn;
+ case Expression::Operation::kStartsWith:
+ return Expression::Operation::kNotStartsWith;
+ case Expression::Operation::kNotStartsWith:
+ return Expression::Operation::kStartsWith;
+ case Expression::Operation::kTrue:
+ case Expression::Operation::kFalse:
+ case Expression::Operation::kNot:
Review Comment:
I'm following the Java impl:
https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/expressions/Expression.java#L64-L97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
