pvary commented on code in PR #13786:
URL: https://github.com/apache/iceberg/pull/13786#discussion_r2414340346
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -1422,16 +1428,35 @@ public <D> CloseableIterable<D> build() {
}
if (batchedReaderFunc != null) {
- return new VectorizedParquetReader<>(
- file,
- schema,
- options,
- batchedReaderFunc,
- mapping,
- filter,
- reuseContainers,
- caseSensitive,
- maxRecordsPerBatch);
+ if (isComet) {
+ LOG.info("Comet vectorized reader enabled");
+ return new CometVectorizedParquetReader<>(
Review Comment:
Based on the suggestion on that PR, we will just handle Comet as an internal
detail for Parquet. So it will be hidden behind the FileFormat API.
Likely the `this.isComet` will be driven by a
[configuration](https://github.com/apache/iceberg/pull/12774/files#diff-27afe27a8ce3704fffd857cfbe78654bea2d79b97120165ee978cfedde57a045R77)
Map for the ReadBuilder, but forget about it now. It is not much of a
complexity, and we will be handling it when the time comes.
Thanks for your consideration!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
