amogh-jahagirdar commented on code in PR #14261:
URL: https://github.com/apache/iceberg/pull/14261#discussion_r2412138258
##########
parquet/src/main/java/org/apache/iceberg/parquet/TypeWithSchemaVisitor.java:
##########
@@ -64,7 +64,7 @@ public static <T> T visit(
} else if (annotation instanceof
LogicalTypeAnnotation.VariantLogicalTypeAnnotation
|| (iType != null && iType.isVariantType())) {
// when Parquet has a VARIANT logical type, use it here
- return visitVariant(iType.asVariantType(), group, visitor);
+ return visitVariant(iType != null ? iType.asVariantType() : null,
group, visitor);
Review Comment:
Well sorry, I mean more generally this applies any case the visitor is
visiting type where there's no iceberg type but there's a parquet type. The
issue probably manifests during pruning though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
