WillAyd commented on code in PR #230: URL: https://github.com/apache/iceberg-cpp/pull/230#discussion_r2420763292
########## src/iceberg/catalog/CMakeLists.txt: ########## @@ -17,6 +17,8 @@ iceberg_install_all_headers(iceberg/catalog) Review Comment: FYI since the in_memory_catalog.h header was removed, this no longer installs anything. Maybe worth removing? ########## src/iceberg/catalog/CMakeLists.txt: ########## @@ -17,6 +17,8 @@ iceberg_install_all_headers(iceberg/catalog) Review Comment: FYI since the in_memory_catalog.h header was moved, this no longer installs anything. Maybe worth removing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
