pvary commented on code in PR #14245:
URL: https://github.com/apache/iceberg/pull/14245#discussion_r2439457949
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/data/FlinkValueReaders.java:
##########
@@ -191,10 +191,10 @@ private static class TimestampNanosReader implements
ValueReader<TimestampData>
@Override
public TimestampData read(Decoder decoder, Object reuse) throws
IOException {
- long nanos = decoder.readLong();
- long mills = Math.floorDiv(nanos, 1_000_000);
- int leftover = Math.floorMod(nanos, 1_000_000);
- return TimestampData.fromEpochMillis(mills, leftover);
+ long storedValue = decoder.readLong();
+ long mills = Math.floorDiv(storedValue, 1_000_000L);
+ int leftoverNanos = (int) Math.floorMod(storedValue, 1_000_000L);
+ return TimestampData.fromEpochMillis(mills, leftoverNanos);
Review Comment:
Any relevant change here?
For me this seems like we renamed some of the variables, but nothing has
changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
