nastra commented on issue #13580: URL: https://github.com/apache/iceberg/issues/13580#issuecomment-3322717950
I took a quick look at both PRs. You might want to look at previous PRs that were introducing request/response classes for REST-specific things, such as https://github.com/apache/iceberg/commit/1cb88a64f8a065c87eb875cf08cfc70941a2fd05 or https://github.com/apache/iceberg/commit/f19643a93f5dac99bbdbc9881ef19c89d7bcd3eb. All of the request/response classes need to be in their respective packages and also have a separate JSON parser class with testing. Those JSON parsers need to be registered for ser/de in `RESTSerializers`. Additionally, all of the new types need to live under the `rest` package in `iceberg-core` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
