huaxingao commented on code in PR #14362:
URL: https://github.com/apache/iceberg/pull/14362#discussion_r2441723243
##########
api/src/main/java/org/apache/iceberg/types/Conversions.java:
##########
@@ -177,6 +191,8 @@ private static Object internalFromByteBuffer(Type type,
ByteBuffer buffer) {
byte[] unscaledBytes = new byte[buffer.remaining()];
tmp.get(unscaledBytes);
return new BigDecimal(new BigInteger(unscaledBytes), decimal.scale());
+ case VARIANT:
+ return Variant.from(buffer);
Review Comment:
nit: shall we use `tmp` instead of `buffer` to honor the LE order that was
set above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
