stevenzwu commented on code in PR #13933: URL: https://github.com/apache/iceberg/pull/13933#discussion_r2409342318
########## core/src/main/java/org/apache/iceberg/stats/BaseContentStats.java: ########## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.stats; + +import java.io.Serializable; +import java.util.List; +import java.util.Objects; +import java.util.Set; +import java.util.stream.Collectors; +import org.apache.iceberg.StructLike; +import org.apache.iceberg.data.GenericRecord; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.types.Type; +import org.apache.iceberg.types.Types; + +public class BaseContentStats implements ContentStats, StructLike, Serializable { + + private final List<FieldStats<?>> fieldStats; + + /** Used by Avro reflection to instantiate this class when reading manifest files. */ + public BaseContentStats(Types.StructType projection) { + this.fieldStats = Lists.newArrayListWithCapacity(projection.fields().size()); + for (int i = 0; i < projection.fields().size(); i++) { + Types.NestedField field = projection.fields().get(i); + Preconditions.checkArgument( + field.type().isStructType(), "ColumnStats must contain structs: %s", field.type()); Review Comment: nit on error msg: `Field stats must be a struct type: %s` ########## api/src/main/java/org/apache/iceberg/stats/StatsUtil.java: ########## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.stats; + +import static org.apache.iceberg.types.Types.NestedField.optional; + +import java.util.Comparator; +import java.util.List; +import java.util.Objects; +import java.util.Set; +import java.util.stream.Collectors; +import org.apache.iceberg.Schema; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.relocated.com.google.common.collect.Sets; +import org.apache.iceberg.types.Type; +import org.apache.iceberg.types.TypeUtil; +import org.apache.iceberg.types.Types; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class StatsUtil { + private static final Logger LOG = LoggerFactory.getLogger(StatsUtil.class); + static final int VALUE_COUNT_OFFSET = 0; + static final int NULL_VALUE_COUNT_OFFSET = 1; + static final int NAN_VALUE_COUNT_OFFSET = 2; + static final int AVG_VALUE_SIZE_OFFSET = 3; + static final int MAX_VALUE_SIZE_OFFSET = 4; + static final int LOWER_BOUND_OFFSET = 5; + static final int UPPER_BOUND_OFFSET = 6; + static final int NUM_STATS_PER_COLUMN = 200; + static final int RESERVED_FIELD_IDS = 200; + static final int DATA_SPACE_FIELD_ID_START = 10_000; + static final int METADATA_SPACE_FIELD_ID_START = 2_147_000_000; + static final int RESERVED_FIELD_IDS_START = Integer.MAX_VALUE - RESERVED_FIELD_IDS; + // support stats for only up to this amount of data field IDs + static final int MAX_DATA_FIELD_ID = 1_000_000; + static final int MAX_DATA_STATS_FIELD_ID = 200_010_000; + + private StatsUtil() {} + + public static int statsFieldIdForField(int fieldId) { + return fieldId >= RESERVED_FIELD_IDS_START + ? statsFieldIdForReservedField(fieldId) + : statsFieldIdForDataField(fieldId); + } + + private static int statsFieldIdForDataField(int fieldId) { + long statsFieldId = DATA_SPACE_FIELD_ID_START + NUM_STATS_PER_COLUMN * (long) fieldId; + if (fieldId < 0 || fieldId > MAX_DATA_FIELD_ID || statsFieldId < 0) { + return -1; + } + + return (int) statsFieldId; + } + + private static int statsFieldIdForReservedField(int fieldId) { + int offset = RESERVED_FIELD_IDS - (Integer.MAX_VALUE - fieldId); + + long statsFieldId = METADATA_SPACE_FIELD_ID_START + NUM_STATS_PER_COLUMN * (long) offset; + if (statsFieldId < 0 || statsFieldId > RESERVED_FIELD_IDS_START) { + // ID overflows + return -1; + } + + return (int) statsFieldId; + } + + public static int fieldIdForStatsField(int statsFieldId) { + if (statsFieldId < DATA_SPACE_FIELD_ID_START || statsFieldId % NUM_STATS_PER_COLUMN != 0) { + return -1; + } + + return statsFieldId < METADATA_SPACE_FIELD_ID_START + ? fieldIdForStatsFieldFromDataField(statsFieldId) + : fieldIdForStatsFieldFromReservedField(statsFieldId); + } + + private static int fieldIdForStatsFieldFromDataField(int statsFieldId) { + return Math.max(-1, (statsFieldId - DATA_SPACE_FIELD_ID_START) / NUM_STATS_PER_COLUMN); + } + + private static int fieldIdForStatsFieldFromReservedField(int statsFieldId) { + return Math.max( + -1, + statsFieldId + - RESERVED_FIELD_IDS + + (Integer.MAX_VALUE - statsFieldId) + + (statsFieldId - METADATA_SPACE_FIELD_ID_START) / NUM_STATS_PER_COLUMN); + } + + public static Types.NestedField contentStatsFor(Schema schema) { + ContentStatsSchemaVisitor visitor = new ContentStatsSchemaVisitor(); + Types.NestedField result = TypeUtil.visit(schema, visitor); + if (!visitor.skippedFieldIds.isEmpty()) { + LOG.warn( + "Could not create stats schema for field ids {} of schema: {}", + visitor.skippedFieldIds, + schema.asStruct()); + } + + return result; + } + + private static Types.StructType contentStatsFor(Type type, int id) { Review Comment: nit: id -> startingFieldId? ########## core/src/main/java/org/apache/iceberg/stats/BaseContentStats.java: ########## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.stats; + +import java.io.Serializable; +import java.util.List; +import java.util.Objects; +import java.util.Set; +import java.util.stream.Collectors; +import org.apache.iceberg.StructLike; +import org.apache.iceberg.data.GenericRecord; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.types.Type; +import org.apache.iceberg.types.Types; + +public class BaseContentStats implements ContentStats, StructLike, Serializable { + + private final List<FieldStats<?>> fieldStats; + + /** Used by Avro reflection to instantiate this class when reading manifest files. */ + public BaseContentStats(Types.StructType projection) { + this.fieldStats = Lists.newArrayListWithCapacity(projection.fields().size()); + for (int i = 0; i < projection.fields().size(); i++) { + Types.NestedField field = projection.fields().get(i); + Preconditions.checkArgument( + field.type().isStructType(), "ColumnStats must contain structs: %s", field.type()); + Types.StructType structType = field.type().asStructType(); + Type type = Review Comment: nested ternary operator is a bit difficult to read. change it to a method that uses if-else? maybe we should also check that if both lower_bound and upper_bound are not null, they should have the same type. ########## api/src/main/java/org/apache/iceberg/stats/StatsUtil.java: ########## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.stats; + +import static org.apache.iceberg.types.Types.NestedField.optional; + +import java.util.Comparator; +import java.util.List; +import java.util.Objects; +import java.util.Set; +import java.util.stream.Collectors; +import org.apache.iceberg.Schema; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.relocated.com.google.common.collect.Sets; +import org.apache.iceberg.types.Type; +import org.apache.iceberg.types.TypeUtil; +import org.apache.iceberg.types.Types; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class StatsUtil { + private static final Logger LOG = LoggerFactory.getLogger(StatsUtil.class); + static final int VALUE_COUNT_OFFSET = 0; + static final int NULL_VALUE_COUNT_OFFSET = 1; + static final int NAN_VALUE_COUNT_OFFSET = 2; + static final int AVG_VALUE_SIZE_OFFSET = 3; + static final int MAX_VALUE_SIZE_OFFSET = 4; + static final int LOWER_BOUND_OFFSET = 5; + static final int UPPER_BOUND_OFFSET = 6; + static final int NUM_STATS_PER_COLUMN = 200; + static final int RESERVED_FIELD_IDS = 200; + static final int DATA_SPACE_FIELD_ID_START = 10_000; + static final int METADATA_SPACE_FIELD_ID_START = 2_147_000_000; + static final int RESERVED_FIELD_IDS_START = Integer.MAX_VALUE - RESERVED_FIELD_IDS; + // support stats for only up to this amount of data field IDs + static final int MAX_DATA_FIELD_ID = 1_000_000; + static final int MAX_DATA_STATS_FIELD_ID = 200_010_000; + + private StatsUtil() {} + + public static int statsFieldIdForField(int fieldId) { + return fieldId >= RESERVED_FIELD_IDS_START + ? statsFieldIdForReservedField(fieldId) + : statsFieldIdForDataField(fieldId); + } + + private static int statsFieldIdForDataField(int fieldId) { + long statsFieldId = DATA_SPACE_FIELD_ID_START + NUM_STATS_PER_COLUMN * (long) fieldId; + if (fieldId < 0 || fieldId > MAX_DATA_FIELD_ID || statsFieldId < 0) { + return -1; + } + + return (int) statsFieldId; + } + + private static int statsFieldIdForReservedField(int fieldId) { + int offset = RESERVED_FIELD_IDS - (Integer.MAX_VALUE - fieldId); + + long statsFieldId = METADATA_SPACE_FIELD_ID_START + NUM_STATS_PER_COLUMN * (long) offset; + if (statsFieldId < 0 || statsFieldId > RESERVED_FIELD_IDS_START) { + // ID overflows + return -1; + } + + return (int) statsFieldId; + } + + public static int fieldIdForStatsField(int statsFieldId) { + if (statsFieldId < DATA_SPACE_FIELD_ID_START || statsFieldId % NUM_STATS_PER_COLUMN != 0) { + return -1; + } + + return statsFieldId < METADATA_SPACE_FIELD_ID_START + ? fieldIdForStatsFieldFromDataField(statsFieldId) + : fieldIdForStatsFieldFromReservedField(statsFieldId); + } + + private static int fieldIdForStatsFieldFromDataField(int statsFieldId) { + return Math.max(-1, (statsFieldId - DATA_SPACE_FIELD_ID_START) / NUM_STATS_PER_COLUMN); + } + + private static int fieldIdForStatsFieldFromReservedField(int statsFieldId) { + return Math.max( + -1, + statsFieldId + - RESERVED_FIELD_IDS + + (Integer.MAX_VALUE - statsFieldId) + + (statsFieldId - METADATA_SPACE_FIELD_ID_START) / NUM_STATS_PER_COLUMN); + } + + public static Types.NestedField contentStatsFor(Schema schema) { + ContentStatsSchemaVisitor visitor = new ContentStatsSchemaVisitor(); + Types.NestedField result = TypeUtil.visit(schema, visitor); + if (!visitor.skippedFieldIds.isEmpty()) { + LOG.warn( + "Could not create stats schema for field ids {} of schema: {}", + visitor.skippedFieldIds, + schema.asStruct()); + } + + return result; + } + + private static Types.StructType contentStatsFor(Type type, int id) { + return Types.StructType.of( + optional( + id + VALUE_COUNT_OFFSET, + "value_count", + Types.LongType.get(), + "Total value count, including null and NaN"), + optional( + id + NULL_VALUE_COUNT_OFFSET, + "null_value_count", + Types.LongType.get(), + "Total null value count"), + optional( + id + NAN_VALUE_COUNT_OFFSET, + "nan_value_count", + Types.LongType.get(), + "Total NaN value count"), + optional( + id + AVG_VALUE_SIZE_OFFSET, + "avg_value_size", + Types.IntegerType.get(), + "Avg value size of variable-length types (String, Binary)"), + optional( + id + MAX_VALUE_SIZE_OFFSET, + "max_value_size", + Types.IntegerType.get(), + "Max value size of variable-length types (String, Binary)"), + optional(id + LOWER_BOUND_OFFSET, "lower_bound", type, "Lower bound"), + optional(id + UPPER_BOUND_OFFSET, "upper_bound", type, "Upper bound")); + } + + private static class ContentStatsSchemaVisitor extends TypeUtil.SchemaVisitor<Types.NestedField> { + private final List<Types.NestedField> statsFields = Lists.newArrayList(); + private final Set<Integer> skippedFieldIds = Sets.newLinkedHashSet(); + + @Override + public Types.NestedField schema(Schema schema, Types.NestedField structResult) { + return optional( + 146, + "content_stats", + Types.StructType.of( + statsFields.stream() + .filter(Objects::nonNull) + .sorted(Comparator.comparing(Types.NestedField::fieldId)) + .collect(Collectors.toList()))); + } + + @Override + public Types.NestedField list(Types.ListType list, Types.NestedField elementResult) { + list.fields() + .forEach( + field -> { + Types.NestedField result = field(field, null); + if (null != result) { + statsFields.add(result); + } + }); + return null; + } + + @Override + public Types.NestedField map( + Types.MapType map, Types.NestedField keyResult, Types.NestedField valueResult) { + map.fields() + .forEach( + field -> { + Types.NestedField result = field(field, null); + if (null != result) { + statsFields.add(result); + } + }); + return null; + } + + @Override + public Types.NestedField struct(Types.StructType struct, List<Types.NestedField> fields) { + statsFields.addAll(fields); + return null; + } + + @Override + public Types.NestedField field(Types.NestedField field, Types.NestedField fieldResult) { + if (field.type().isNestedType() || field.type().isVariantType()) { + return null; + } + + int fieldId = StatsUtil.statsFieldIdForField(field.fieldId()); + // don't overflow and don't overlap with the metadata ID range + if (fieldId >= 0) { + Types.StructType structType = contentStatsFor(field.type(), fieldId + 1); Review Comment: oh. I think I understand now. the struct field itself has `fieldId`. the child stats field start with offset 0. that's why we need the `+ 1` here. might be a bit more natural to have offset starting at 1 and remove the `+ 1` here. but it could be just my personal taste. ########## api/src/main/java/org/apache/iceberg/stats/StatsUtil.java: ########## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.stats; + +import static org.apache.iceberg.types.Types.NestedField.optional; + +import java.util.Comparator; +import java.util.List; +import java.util.Objects; +import java.util.Set; +import java.util.stream.Collectors; +import org.apache.iceberg.Schema; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.relocated.com.google.common.collect.Sets; +import org.apache.iceberg.types.Type; +import org.apache.iceberg.types.TypeUtil; +import org.apache.iceberg.types.Types; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class StatsUtil { + private static final Logger LOG = LoggerFactory.getLogger(StatsUtil.class); + static final int VALUE_COUNT_OFFSET = 0; + static final int NULL_VALUE_COUNT_OFFSET = 1; + static final int NAN_VALUE_COUNT_OFFSET = 2; + static final int AVG_VALUE_SIZE_OFFSET = 3; + static final int MAX_VALUE_SIZE_OFFSET = 4; + static final int LOWER_BOUND_OFFSET = 5; + static final int UPPER_BOUND_OFFSET = 6; + static final int NUM_STATS_PER_COLUMN = 200; + static final int RESERVED_FIELD_IDS = 200; + static final int DATA_SPACE_FIELD_ID_START = 10_000; + static final int METADATA_SPACE_FIELD_ID_START = 2_147_000_000; + static final int RESERVED_FIELD_IDS_START = Integer.MAX_VALUE - RESERVED_FIELD_IDS; + // support stats for only up to this amount of data field IDs + static final int MAX_DATA_FIELD_ID = 1_000_000; + static final int MAX_DATA_STATS_FIELD_ID = 200_010_000; + + private StatsUtil() {} + + public static int statsFieldIdForField(int fieldId) { + return fieldId >= RESERVED_FIELD_IDS_START + ? statsFieldIdForReservedField(fieldId) + : statsFieldIdForDataField(fieldId); + } + + private static int statsFieldIdForDataField(int fieldId) { + long statsFieldId = DATA_SPACE_FIELD_ID_START + NUM_STATS_PER_COLUMN * (long) fieldId; + if (fieldId < 0 || fieldId > MAX_DATA_FIELD_ID || statsFieldId < 0) { + return -1; + } + + return (int) statsFieldId; + } + + private static int statsFieldIdForReservedField(int fieldId) { + int offset = RESERVED_FIELD_IDS - (Integer.MAX_VALUE - fieldId); + + long statsFieldId = METADATA_SPACE_FIELD_ID_START + NUM_STATS_PER_COLUMN * (long) offset; + if (statsFieldId < 0 || statsFieldId > RESERVED_FIELD_IDS_START) { + // ID overflows + return -1; + } + + return (int) statsFieldId; + } + + public static int fieldIdForStatsField(int statsFieldId) { + if (statsFieldId < DATA_SPACE_FIELD_ID_START || statsFieldId % NUM_STATS_PER_COLUMN != 0) { + return -1; + } + + return statsFieldId < METADATA_SPACE_FIELD_ID_START + ? fieldIdForStatsFieldFromDataField(statsFieldId) + : fieldIdForStatsFieldFromReservedField(statsFieldId); + } + + private static int fieldIdForStatsFieldFromDataField(int statsFieldId) { + return Math.max(-1, (statsFieldId - DATA_SPACE_FIELD_ID_START) / NUM_STATS_PER_COLUMN); + } + + private static int fieldIdForStatsFieldFromReservedField(int statsFieldId) { + return Math.max( + -1, + statsFieldId + - RESERVED_FIELD_IDS + + (Integer.MAX_VALUE - statsFieldId) + + (statsFieldId - METADATA_SPACE_FIELD_ID_START) / NUM_STATS_PER_COLUMN); + } + + public static Types.NestedField contentStatsFor(Schema schema) { + ContentStatsSchemaVisitor visitor = new ContentStatsSchemaVisitor(); + Types.NestedField result = TypeUtil.visit(schema, visitor); + if (!visitor.skippedFieldIds.isEmpty()) { + LOG.warn( + "Could not create stats schema for field ids {} of schema: {}", + visitor.skippedFieldIds, + schema.asStruct()); + } + + return result; + } + + private static Types.StructType contentStatsFor(Type type, int id) { + return Types.StructType.of( + optional( + id + VALUE_COUNT_OFFSET, + "value_count", + Types.LongType.get(), + "Total value count, including null and NaN"), + optional( + id + NULL_VALUE_COUNT_OFFSET, + "null_value_count", + Types.LongType.get(), + "Total null value count"), + optional( + id + NAN_VALUE_COUNT_OFFSET, + "nan_value_count", + Types.LongType.get(), + "Total NaN value count"), + optional( + id + AVG_VALUE_SIZE_OFFSET, + "avg_value_size", + Types.IntegerType.get(), + "Avg value size of variable-length types (String, Binary)"), + optional( + id + MAX_VALUE_SIZE_OFFSET, + "max_value_size", + Types.IntegerType.get(), + "Max value size of variable-length types (String, Binary)"), + optional(id + LOWER_BOUND_OFFSET, "lower_bound", type, "Lower bound"), + optional(id + UPPER_BOUND_OFFSET, "upper_bound", type, "Upper bound")); + } + + private static class ContentStatsSchemaVisitor extends TypeUtil.SchemaVisitor<Types.NestedField> { + private final List<Types.NestedField> statsFields = Lists.newArrayList(); + private final Set<Integer> skippedFieldIds = Sets.newLinkedHashSet(); + + @Override + public Types.NestedField schema(Schema schema, Types.NestedField structResult) { + return optional( + 146, + "content_stats", + Types.StructType.of( + statsFields.stream() + .filter(Objects::nonNull) + .sorted(Comparator.comparing(Types.NestedField::fieldId)) + .collect(Collectors.toList()))); + } + + @Override + public Types.NestedField list(Types.ListType list, Types.NestedField elementResult) { + list.fields() + .forEach( + field -> { + Types.NestedField result = field(field, null); + if (null != result) { + statsFields.add(result); + } + }); + return null; + } + + @Override + public Types.NestedField map( + Types.MapType map, Types.NestedField keyResult, Types.NestedField valueResult) { + map.fields() + .forEach( + field -> { + Types.NestedField result = field(field, null); + if (null != result) { + statsFields.add(result); + } + }); + return null; + } + + @Override + public Types.NestedField struct(Types.StructType struct, List<Types.NestedField> fields) { + statsFields.addAll(fields); + return null; + } + + @Override + public Types.NestedField field(Types.NestedField field, Types.NestedField fieldResult) { + if (field.type().isNestedType() || field.type().isVariantType()) { + return null; + } + + int fieldId = StatsUtil.statsFieldIdForField(field.fieldId()); + // don't overflow and don't overlap with the metadata ID range + if (fieldId >= 0) { + Types.StructType structType = contentStatsFor(field.type(), fieldId + 1); Review Comment: nm. offset starting at 0 works better with the get by position for StructLike ########## core/src/main/java/org/apache/iceberg/stats/BaseContentStats.java: ########## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.stats; + +import java.io.Serializable; +import java.util.List; +import java.util.Objects; +import java.util.Set; +import java.util.stream.Collectors; +import org.apache.iceberg.StructLike; +import org.apache.iceberg.data.GenericRecord; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.types.Type; +import org.apache.iceberg.types.Types; + +public class BaseContentStats implements ContentStats, StructLike, Serializable { + + private final List<FieldStats<?>> fieldStats; + + /** Used by Avro reflection to instantiate this class when reading manifest files. */ + public BaseContentStats(Types.StructType projection) { + this.fieldStats = Lists.newArrayListWithCapacity(projection.fields().size()); + for (int i = 0; i < projection.fields().size(); i++) { + Types.NestedField field = projection.fields().get(i); + Preconditions.checkArgument( + field.type().isStructType(), "ColumnStats must contain structs: %s", field.type()); + Types.StructType structType = field.type().asStructType(); + Type type = + null != structType.field("lower_bound") + ? structType.field("lower_bound").type() + : null != structType.field("upper_bound") + ? structType.field("upper_bound").type() + : null; + fieldStats.add( + BaseFieldStats.builder() + .fieldId(StatsUtil.fieldIdForStatsField(field.fieldId())) + .type(type) + .build()); + } + } + + private BaseContentStats(List<FieldStats<?>> fieldStats) { + this.fieldStats = Lists.newArrayList(fieldStats); + } + + @Override + public List<FieldStats<?>> fieldStats() { + return fieldStats; + } + + @Override + public int size() { + return fieldStats.size(); + } + + @Override + public <T> T get(int pos, Class<T> javaClass) { + if (pos < 0 || pos > fieldStats().size() - 1) { + return null; + } + + FieldStats<?> value = fieldStats.get(pos); Review Comment: we are simulating a StructLike with a list? seems a little odd to me. does this class need to be `StructLike`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
