nastra commented on code in PR #14027:
URL: https://github.com/apache/iceberg/pull/14027#discussion_r2419071391


##########
data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java:
##########
@@ -1063,6 +1073,41 @@ public void testVariantFieldAllNullsNotNull() throws 
IOException {
     }
   }
 
+  @TestTemplate
+  public void testUUID() {
+    assumeThat(format).as("Only valid for 
Parquet").isEqualTo(FileFormat.PARQUET);
+
+    UUID nonExistentUuid = 
UUID.fromString("99999999-9999-9999-9999-999999999999");
+
+    boolean shouldRead = shouldRead(notEqual("uuid_col", UUID_WITH_ZEROS));

Review Comment:
   the test is still missing equal/greaterThan/lessThan



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to