dentiny commented on code in PR #1747:
URL: https://github.com/apache/iceberg-rust/pull/1747#discussion_r2431097578
##########
crates/iceberg/src/arrow/reader.rs:
##########
@@ -1390,9 +1392,21 @@ impl<R: FileRead> AsyncFileReader for ArrowFileReader<R>
{
async move {
let reader = ParquetMetaDataReader::new()
.with_prefetch_hint(self.metadata_size_hint)
- .with_column_indexes(self.preload_column_index)
- .with_page_indexes(self.preload_page_index)
- .with_offset_indexes(self.preload_offset_index);
+ .with_column_index_policy(if self.preload_column_index {
Review Comment:
Old API already deprecated
```sh
warning: use of deprecated method
parquet::file::metadata::ParquetMetaDataReader::with_column_indexes: Use
with_column_index_policy instead --> crates/iceberg/src/arrow/reader.rs:1393:18
| 1393 | .with_column_indexes(self.preload_column_index) | ^^^^^^^^^^^^^^^^^^^
| = note: #[warn(deprecated)] on by default warning: use of deprecated method
parquet::file::metadata::ParquetMetaDataReader::with_page_indexes: Use
with_page_index_policy instead --> crates/iceberg/src/arrow/reader.rs:1394:18 |
1394 | .with_page_indexes(self.preload_page_index) | ^^^^^^^^^^^^^^^^^ warning:
use of deprecated method
parquet::file::metadata::ParquetMetaDataReader::with_offset_indexes: Use
with_offset_index_policy instead --> crates/iceberg/src/arrow/reader.rs:1395:18
| 1395 | .with_offset_indexes(self.preload_offset_index); | ^^^^^^^^^^^^^^^^^^^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
