rambleraptor commented on code in PR #2595:
URL: https://github.com/apache/iceberg-python/pull/2595#discussion_r2418075311
##########
tests/integration/test_catalog.py:
##########
@@ -355,3 +355,40 @@ def test_update_namespace_properties(test_catalog:
Catalog, database_name: str)
else:
assert k in update_report.removed
assert "updated test description" ==
test_catalog.load_namespace_properties(database_name)["comment"]
+
+
[email protected]
[email protected]("test_catalog", CATALOGS)
+def test_register_table(test_catalog: Catalog, table_name: str, database_name:
str) -> None:
Review Comment:
Vonsider using `table_schema_simple` or `table_schema_nested` as opposed to
an empty schema.
The old tests used a more rigorous schema, which might uncover future issues
in `register_table`. Especially if this test is used to verify an arbitrary
REST Catalog Implementation
##########
tests/integration/test_catalog.py:
##########
@@ -355,3 +355,40 @@ def test_update_namespace_properties(test_catalog:
Catalog, database_name: str)
else:
assert k in update_report.removed
assert "updated test description" ==
test_catalog.load_namespace_properties(database_name)["comment"]
+
+
[email protected]
[email protected]("test_catalog", CATALOGS)
+def test_register_table(test_catalog: Catalog, table_name: str, database_name:
str) -> None:
Review Comment:
Consider using `table_schema_simple` or `table_schema_nested` as opposed to
an empty schema.
The old tests used a more rigorous schema, which might uncover future issues
in `register_table`. Especially if this test is used to verify an arbitrary
REST Catalog Implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
