hydrogenlee commented on PR #14080: URL: https://github.com/apache/iceberg/pull/14080#issuecomment-3388064112
Sorry, I will close the PR because I’ve been quite busy lately,. I hope someone can help me resolve this issue, thanks. PS: 1. If the state is cleared in `initializeState`, unit testing might be more difficult, because no matter what is done in `snapshotState`, after executing `initializeState`, all the state is cleared. 2. Conversely, unit testing might be easier: we can check whether an exception is thrown (if we throw an exception inside `initializeState`), or after executing `initializeState`, check whether the state contains only one item (while not throwing exceptions to avoid compatibility issues). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
