zeroshade commented on code in PR #583:
URL: https://github.com/apache/iceberg-go/pull/583#discussion_r2406894990
##########
table/snapshots.go:
##########
@@ -293,13 +294,13 @@ func (s Snapshot) Equals(other Snapshot) bool {
s.Summary.Equals(other.Summary)
}
-func (s Snapshot) Manifests(fio iceio.IO) ([]iceberg.ManifestFile, error) {
+func (s Snapshot) Manifests(fio iceio.IO) (_ []iceberg.ManifestFile, err
error) {
if s.ManifestList != "" {
f, err := fio.Open(s.ManifestList)
if err != nil {
return nil, fmt.Errorf("could not open manifest file:
%w", err)
}
- defer f.Close()
+ defer internal.CheckedClose(f, &err)
return iceberg.ReadManifestList(f)
}
Review Comment:
same comments as elsewhere, this won't propagate it as you expect, and we
don't need the named vars in the return
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
