CTTY commented on code in PR #1735: URL: https://github.com/apache/iceberg-rust/pull/1735#discussion_r2418456671
########## crates/iceberg/src/writer/partitioning/clustered_data_writer.rs: ########## @@ -0,0 +1,600 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! This module provides the `ClusteredDataWriter` implementation. + +use std::collections::HashSet; + +use arrow_array::RecordBatch; +use async_trait::async_trait; + +use crate::spec::{DataFile, PartitionKey, Struct}; +use crate::writer::partitioning::PartitioningWriter; +use crate::writer::{IcebergWriter, IcebergWriterBuilder}; +use crate::{Error, ErrorKind, Result}; + +/// A writer that writes data to a single partition at a time. +#[derive(Clone)] +pub struct ClusteredDataWriter<B: IcebergWriterBuilder> { Review Comment: ClusteredDataWriter and FanoutDataWriter are supposed to only work with `DefaultInput` and `DefaultOutput`. I tried including generic i/o few weeks ago and remember there were tons of tricky nuances and decided to just go for the default IO type for now. For other IO type(e.g. [PositionalDeleteInput](https://github.com/apache/iceberg-rust/pull/704/files#diff-a72530499570c15a16d05e7a8c79408fffac9760784eabf1851c66aaaf925e26R62)), we will need add another implementation later. Also maybe we should name these `DefaultClustered/FanoutWriter` to avoid confusion since they can also write equality deletes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
