ebyhr commented on code in PR #14360:
URL: https://github.com/apache/iceberg/pull/14360#discussion_r2441295056
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -529,6 +533,11 @@ public Builder withAuthSession(AuthSession session) {
return this;
}
+ public Builder withOpenTelemetry(OpenTelemetry openTelemetry) {
+ this.telemetry = openTelemetry;
+ return this;
+ }
Review Comment:
Just passing `OpenTelemetry` instance is sufficient in this repository.
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
Review Comment:
Right, Trino provides RESTClient builder in TrinoIcebergRestCatalogFactory.
https://github.com/trinodb/trino/blob/4da16d9597ecc4750f3d499f3975c4f1337c76c7/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/rest/TrinoIcebergRestCatalogFactory.java#L135-L138
The new code will be like this:
```java
config -> HTTPClient.builder(config)
.uri(config.get(CatalogProperties.URI))
.withHeaders(RESTUtil.configHeaders(config))
. withOpenTelemetry(openTelemetry)
.build(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
