fuatbasik commented on PR #14247:
URL: https://github.com/apache/iceberg/pull/14247#issuecomment-3375870230
Hi @singhpk234. Thanks a lot for your comments. @stubz151 is out of office
but I can answer your questions until he is back.
> Since these are removing public interfaces directly, wondering if we
should mark them deprecated first ? and set a version where we want them to get
removed.
AFAIK these interfaces currently only used by AnalyticsStream. They were
added when we initially added the stream but during the community sync at 8/27
there were concerns about the developer experience. If you still think we
should deprecate them first, we can update it.
>
> Also curious, if you can share benchmarks you sighted above.
We recently added sync client to our microbenchmarks:
https://github.com/awslabs/analytics-accelerator-s3/tree/main/input-stream/src/jmh
and havent seen much difference between sync and async client. This is mostly
because Analytics Accelerator already handles async logic itself, so no need
for additional client complexity. It will still support Async client though,
for users who are already in Async client. But as initially we introduced Async
client. Following aforementioned community feedback about developer experince,
we though we can remove Async client integration from Iceberg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
