CTTY opened a new issue, #1753:
URL: https://github.com/apache/iceberg-rust/issues/1753

   ### Is your feature request related to a problem or challenge?
   
   As mentioned here: 
https://github.com/apache/iceberg-rust/pull/1735#discussion_r2428605135
   
   Currently `IcebergWriterBuilder`, `RollingFileWriterBuilder`, and 
`FileWriterBuilder` all have `build(self)` and will consume itself when 
building the writer.
   
   This will force users to clone the builders a lot if they want to use the 
same configuration for multiple writers.
   ```
   let writer1 = builder.clone().build();
   let writer2 = builder.clone().build();
   ...  
   ```
   
   ### Describe the solution you'd like
   
   Change the builders to have `build(&self)` so users don't have to clone the 
builders before building.
   
   Note existing builders use `async_trait`, so using `&self`, will probably 
need more trait bound.
   
   ### Willingness to contribute
   
   None


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to