Fokko commented on code in PR #2605:
URL: https://github.com/apache/iceberg-python/pull/2605#discussion_r2440721314
##########
pyproject.toml:
##########
@@ -6,535 +6,706 @@
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
Review Comment:
I've did a check and it seems that it is fine with the format change:
```
➜ iceberg-python git:(pretty-format-toml) ./dev/check-license
ERROR: Ignored 0 lines in your exclusion files as comments or empty lines.
Could not find Apache license headers in the following files:
!????? /Users/fokko.driesprong/work/iceberg-python/coverage.xml
!????? /Users/fokko.driesprong/work/iceberg-python/.idea/iceberg-python.iml
!????? /Users/fokko.driesprong/work/iceberg-python/.idea/misc.xml
!????? /Users/fokko.driesprong/work/iceberg-python/.idea/modules.xml
!????? /Users/fokko.driesprong/work/iceberg-python/.idea/vcs.xml
!????? /Users/fokko.driesprong/work/iceberg-python/.idea/workspace.xml
!?????
/Users/fokko.driesprong/work/iceberg-python/.idea/inspectionProfiles/profiles_settings.xml
!????? /Users/fokko.driesprong/work/iceberg-python/.mypy_cache/CACHEDIR.TAG
!?????
/Users/fokko.driesprong/work/iceberg-python/.pytest_cache/CACHEDIR.TAG
!????? /Users/fokko.driesprong/work/iceberg-python/.pytest_cache/README.md
!?????
/Users/fokko.driesprong/work/iceberg-python/.pytest_cache/v/cache/lastfailed
!?????
/Users/fokko.driesprong/work/iceberg-python/.pytest_cache/v/cache/nodeids
!?????
/Users/fokko.driesprong/work/iceberg-python/.pytest_cache/v/cache/stepwise
!????? /Users/fokko.driesprong/work/iceberg-python/.ruff_cache/CACHEDIR.TAG
!????? /Users/fokko.driesprong/work/iceberg-python/htmlcov/class_index.html
!?????
/Users/fokko.driesprong/work/iceberg-python/htmlcov/function_index.html
!????? /Users/fokko.driesprong/work/iceberg-python/htmlcov/index.html
!?????
/Users/fokko.driesprong/work/iceberg-python/pyiceberg/avro/decoder_fast.c
```
The checker is pretty flexible when it comes to whitespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
