pvary commented on code in PR #14353:
URL: https://github.com/apache/iceberg/pull/14353#discussion_r2439226618
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -68,6 +76,10 @@ public static MetricsConfig getDefault() {
return DEFAULT;
}
+ public static MetricsConfig getPositionDelete() {
Review Comment:
I was debating the same. The `getPositionDelete` won narrowly, because of
the `getDefault`.
But taking a look at it with fresh eyes the `forPositionDelete` seems better.
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
