stevenzwu commented on code in PR #14210:
URL: https://github.com/apache/iceberg/pull/14210#discussion_r2427346291
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkWriterMetrics.java:
##########
@@ -57,4 +59,14 @@ public RowData toGenericRow(int value, int repeated) {
}
return row;
}
+
+ @Override
+ protected void checkRowStatistics(Map<Integer, ByteBuffer> bounds) {
+ assertThat(bounds).hasSize(2);
+ }
+
+ @Override
+ protected void checkNotExistingRowStatistics(Map<Integer, ByteBuffer>
bounds) {
+ assertThat(bounds).isNull();
+ }
Review Comment:
`TestWriterMetrics` has two child implementations: `TestFlinkWriterMetrics`
and `TestSparkWriterMetrics`.
Are we saying that `SparkFileWriterFactory` didn't remove the row content
from the position deletes file?
Otherwise, there is no reason to override the behavior for Flink test.
##########
data/src/test/java/org/apache/iceberg/data/TestGenericFileWriterFactory.java:
##########
@@ -57,4 +59,9 @@ protected StructLikeSet toSet(Iterable<Record> records) {
records.forEach(set::add);
return set;
}
+
+ @Disabled("Position deletes with row data are no longer supported")
+ @Override
+ @TestTemplate
+ public void testPositionDeleteWriterWithRow() throws IOException {}
Review Comment:
what's the purpose to add this new test method that is empty and disabled?
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkFileWriterFactory.java:
##########
@@ -63,4 +65,9 @@ protected StructLikeSet toSet(Iterable<RowData> rows) {
}
return set;
}
+
+ @Disabled("Position deletes with row data are no longer supported")
+ @Override
+ @TestTemplate
+ public void testPositionDeleteWriterWithRow() throws IOException {}
Review Comment:
similarly, I am not sure about the purpose of new test method that is empty
and disabled
##########
data/src/main/java/org/apache/iceberg/data/GenericFileWriterFactory.java:
##########
@@ -37,6 +37,33 @@
class GenericFileWriterFactory extends BaseFileWriterFactory<Record> {
+ GenericFileWriterFactory(
Review Comment:
can we just update the test to this new constructor and avoid the
deprecation step?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
